Skip to content

Conversation

@srl295
Copy link
Member

@srl295 srl295 commented Jan 8, 2026

  • use ROOT_SECONDARY collator
  • expected to fail for now, see parent ticket

CLDR-19192

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Jan 8, 2026
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two small suggestions; otherwise looks great.

@srl295
Copy link
Member Author

srl295 commented Jan 8, 2026

I have two small suggestions; otherwise looks great.

Should this go in as log known issue, with the actual fixes in CLDR-19189 ?

otherwise this can't merge until data fixed

also fix docs around problems and improve parallel stream
@srl295 srl295 requested a review from macchiati January 8, 2026 23:34
@srl295 srl295 marked this pull request as ready for review January 8, 2026 23:34
macchiati
macchiati previously approved these changes Jan 9, 2026
@srl295
Copy link
Member Author

srl295 commented Jan 9, 2026

@macchiati thanks, but should this be a log known issue until the data is fixed? or leave this PR open awaiting data fix? It can't merge as is, since it fails.

@AEApple
Copy link
Contributor

AEApple commented Jan 9, 2026

I think it would be good to add as a logged known issue and then we can discuss in the next TC meeting how the TC prefers to resolve this in 49.

@srl295
Copy link
Member Author

srl295 commented Jan 9, 2026 via email

@macchiati
Copy link
Member

Logged known issue is fine for now, but we need to document this as a Known issue on the 48 release page, with pointer to the ticket/PR that fixes it, so that people can cherry pick.

@srl295
Copy link
Member Author

srl295 commented Jan 9, 2026

logknownissue is as follows:

CLDR-19189 https://unicode-org.atlassian.net/browse/CLDR-19189

  • CLDR/TestAnnotations/TestUniqueness (cased collision in annotations:
    Duplicate name in ba: “Балыҡ” for “♓” & “🐟”(≈“балыҡ”)
    Duplicate name in ba: “Саян” for “♏” & “🦂”(≈“саян”)
    Duplicate name in ba: “Ҡыҙ” for “♍” & “👧”(≈“ҡыҙ”)
    Duplicate name in ba: “Үлсәү” for “♎” & “⚖️”(≈“үлсәү”)
    Duplicate name in ja: “キノコ” for “🍄‍🟫”(≈“きのこ”) & “🍄”
    Duplicate name in ja: “ゴミ箱” for “🗑️”(≈“ごみ箱”) & “🚮”
    Duplicate name in ja: “タコ” for “🪁”(≈“たこ”) & “🐙”
    Duplicate name in rm: “Botsch” for “♈” & “🐏”(≈“botsch”)
    Duplicate name in rm: “Giomber” for “♋” & “🦀”(≈“giomber”)
    Duplicate name in rm: “Liun” for “♌” & “🦁”(≈“liun”)
    Duplicate name in rm: “Scorpiun” for “♏” & “🦂”(≈“scorpiun”)
    Duplicate name in rm: “Um da l’aua” for “♒” & “🧜‍♂️”(≈“um da l’aua”)
    Duplicate name in vi: “Bọ Cạp” for “♏” & “🦂”(≈“bọ cạp”)
    Duplicate name in vi: “Sư Tử” for “♌” & “🦁”(≈“sư tử”) )

macchiati
macchiati previously approved these changes Jan 17, 2026
}

private static Comparator<String> makeNFKC_CF_SECONDARY() {
private static Comparator<String> makeROOT_INSENSITIVE() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better name would be CASE_FOLDED (it has nothing to do with root or collation).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do that in a later round.
sorry for the noise, trying to move this forward

@macchiati macchiati self-requested a review January 17, 2026 23:56
@srl295
Copy link
Member Author

srl295 commented Jan 18, 2026

@macchiati nothing fails, so probably we can remove the logknownissue?

My mistake, these seem to be known issues still

CLDR-19189 <https://unicode-org.atlassian.net/browse/CLDR-19189>
  - CLDR/TestAnnotations/TestUniqueness (cased collision in annotations:
Duplicate name in ja: “キノコ” for “🍄‍🟫”(≈“きのこ”)  & “🍄”
Duplicate name in ja: “ゴミ箱” for “🗑️”(≈“ごみ箱”)  & “🚮”
Duplicate name in ja: “タコ” for “🪁”(≈“たこ”)  & “🐙”)

a little unexpeted, i'll need to investigate monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants